netdev - Re: [PATCH net] tun: Fix use-after-free on XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.133913.6430543033492540.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 13:39:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     makita.toshiaki@....ntt.co.jp
Cc:     netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH net] tun: Fix use-after-free on XDP_TX

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Fri, 13 Jul 2018 13:24:38 +0900

> On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a
> negative value. A positive value indicates that the packet is
> successfully enqueued to the ptr_ring, so freeing the page causes
> use-after-free.
> 
> Fixes: 735fc4054b3a ("xdp: change ndo_xdp_xmit API to support bulking")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied, thank you.