netdev - Re: [PATCH net] net/mlx4_en: Don't reuse RX page when XDP is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.140833.1871284102811541207.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 14:08:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com, kafai@...com,
        saeedm@...lanox.com, edumazet@...gle.com
Subject: Re: [PATCH net] net/mlx4_en: Don't reuse RX page when XDP is set

From: Tariq Toukan <tariqt@...lanox.com>
Date: Sun, 15 Jul 2018 13:54:39 +0300

> From: Saeed Mahameed <saeedm@...lanox.com>
> 
> When a new rx packet arrives, the rx path will decide whether to reuse
> the remainder of the page or not according to one of the below conditions:
> 1. frag_info->frag_stride == PAGE_SIZE / 2
> 2. frags->page_offset + frag_info->frag_size > PAGE_SIZE;
> 
> The first condition is no met for when XDP is set.
> For XDP, page_offset is always set to priv->rx_headroom which is
> XDP_PACKET_HEADROOM and frag_info->frag_size is around mtu size + some
> padding, still the 2nd release condition will hold since
> XDP_PACKET_HEADROOM + 1536 < PAGE_SIZE, as a result the page will not
> be released and will be _wrongly_ reused for next free rx descriptor.
> 
> In XDP there is an assumption to have a page per packet and reuse can
> break such assumption and might cause packet data corruptions.
> 
> Fix this by adding an extra condition (!priv->rx_headroom) to the 2nd
> case to avoid page reuse when XDP is set, since rx_headroom is set to 0
> for non XDP setup and set to XDP_PACKET_HEADROOM for XDP setup.
> 
> No additional cache line is required for the new condition.
> 
> Fixes: 34db548bfb95 ("mlx4: add page recycling in receive path")
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> Suggested-by: Martin KaFai Lau <kafai@...com>

Applied and queued up for -stable.