netdev - Re: [PATCH] net: lan78xx: Fix race in tx pending skb size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.141320.1898046446934093342.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 14:13:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stefan.wahren@...e.com
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        gregkh@...uxfoundation.org, dave.stevenson@...pberrypi.org,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        stable@...r.kernel.org, bos@...eigen-domein.nl
Subject: Re: [PATCH] net: lan78xx: Fix race in tx pending skb size
 calculation

From: Stefan Wahren <stefan.wahren@...e.com>
Date: Sun, 15 Jul 2018 21:53:20 +0200

> The skb size calculation in lan78xx_tx_bh is in race with the start_xmit,
> which could lead to rare kernel oopses. So protect the whole skb walk with
> a spin lock. As a benefit we can unlink the skb directly.
> 
> This patch was tested on Raspberry Pi 3B+
> 
> Link: https://github.com/raspberrypi/linux/issues/2608
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet")
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Floris Bos <bos@...eigen-domein.nl>
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>

Applied and queued up for -stable, thanks.