netdev - Re: [PATCH net] ibmvnic: Fix error recovery on login failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.144008.687460894526079524.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 14:40:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jallen@...ux.ibm.com
Cc:     tlfalcon@...ux.vnet.ibm.com, netdev@...r.kernel.org,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Fix error recovery on login failure

From: John Allen <jallen@...ux.ibm.com>
Date: Mon, 16 Jul 2018 10:29:30 -0500

> Testing has uncovered a failure case that is not handled properly. In the
> event that a login fails and we are not able to recover on the spot, we
> return 0 from do_reset, preventing any error recovery code from being
> triggered.  Additionally, the state is set to "probed" meaning that when we
> are able to trigger the error recovery, the driver always comes up in the
> probed state. To handle the case properly, we need to return a failure code
> here and set the adapter state to the state that we entered the reset in
> indicating the state that we would like to come out of the recovery reset
> in.
> 
> Signed-off-by: John Allen <jallen@...ux.vnet.ibm.com>

Applied, thanks.