netdev - Re: [PATCH v2 iproute2-next 06/31] tc/util: add print helpers for JSON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc59a412-c041-aa20-10a6-38bafa7e011e@gmail.com>
Date:   Mon, 16 Jul 2018 19:05:16 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Cc:     Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH v2 iproute2-next 06/31] tc/util: add print helpers for
 JSON

On 7/10/18 3:05 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <sthemmin@...rosoft.com>
> 
> Add a helper to print rate, time and size in numeric or pretty format
> based on JSON flag.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> ---
>  tc/tc_util.c | 83 +++++++++++++++++++++++++++++++++-------------------
>  tc/tc_util.h |  6 ++++
>  2 files changed, 59 insertions(+), 30 deletions(-)

This one fails to compile on Stretch:

tc
    CC       tc_util.o
tc_util.c:388:6: error: conflicting types for ‘print_time’
 void print_time(const char *key, const char *fmt, __u32 tm)
      ^~~~~~~~~~
In file included from tc_util.c:27:0:
tc_util.h:92:6: note: previous declaration of ‘print_time’ was here
 void print_time(const char *key, const char *fmt, __s32 tm);
      ^~~~~~~~~~
../config.mk:43: recipe for target 'tc_util.o' failed