netdev - Re: [PATCH net-next 3/4] hwmon: Add helper to tell if a char is invalid in a name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 13:12:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King <rmk+kernel@....linux.org.uk>,
        linux-hwmon@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] hwmon: Add helper to tell if a char is
 invalid in a name

On Tue, Jul 17, 2018 at 09:48:12PM +0200, Andrew Lunn wrote:
> HWMON device names are not allowed to contain "-* \t\n". Add a helper
> which will return true if passed an invalid character. It can be used
> to massage a string into a hwmon compatible name by replacing invalid
> characters with '_'.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  include/linux/hwmon.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index b217101ca76e..9493d4a388db 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -398,4 +398,27 @@ devm_hwmon_device_register_with_info(struct device *dev,
>  void hwmon_device_unregister(struct device *dev);
>  void devm_hwmon_device_unregister(struct device *dev);
>  
> +/**
> + * hwmon_is_bad_char - Is the char invalid in a hwmon name
> + * @ch: the char to be considered
> + *
> + * hwmon_is_bad_char() can be used to determine if the given character
> + * may not be used in a hwmon name.
> + *
> + * Returns true if the char is invalid, false otherwise.
> + */
> +static inline bool hwmon_is_bad_char(const char ch)
> +{
> +	switch (ch) {
> +	case '-':
> +	case '*':
> +	case ' ':
> +	case '\t':
> +	case '\n':
> +		return true;
> +	default:
> +		return false;
> +	}
> +}
> +
>  #endif
> -- 
> 2.18.0
>