netdev - Re: [PATCH net-next 1/7] net: dsa: bcm_sf2: Allow targeting CPU ports for CFP rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 09:56:37 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, linville@...driver.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next 1/7] net: dsa: bcm_sf2: Allow targeting CPU
 ports for CFP rules

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 17 Jul 2018 08:36:39 -0700

> @@ -755,7 +755,8 @@ static int bcm_sf2_cfp_rule_set(struct dsa_switch *ds, int port,
>  	port_num = fs->ring_cookie / SF2_NUM_EGRESS_QUEUES;
>  
>  	if (fs->ring_cookie == RX_CLS_FLOW_DISC ||
> -	    !dsa_is_user_port(ds, port_num) ||
> +	    !(dsa_is_user_port(ds, port_num) ||
> +	    dsa_is_cpu_port(ds, port_num)) ||

I think the second new line needs to be indented by two more
spaces, but I could be wrong :-)