netdev - Re: [PATCH net-next] r8169: power down chip in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180718.100349.761671025516145253.davem@davemloft.net>
Date:   Wed, 18 Jul 2018 10:03:49 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: power down chip in probe

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 17 Jul 2018 21:21:37 +0200

> The removed code would be called in two situations:
> 1. interface is brought up never or >10s after driver load
> 2. after close()
> 
> Case 1 we can handle cleaner by ensuring chip is powered down when
> leaving probe(). open() callback will power up the chip.
> 
> In case 2 we call rtl_pll_power_down() twice currently, from the
> close() callback and 10s later when entering runtime-suspend.
> This is avoided by this patch.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thank you.