netdev - Re: [PATCH net-next] net: rename ndo_setup_tc to ndo_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180718163054.GF2184@nanopsycho.orion>
Date:   Wed, 18 Jul 2018 18:30:54 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, thomas.lendacky@....com,
        f.fainelli@...il.com, ariel.elior@...ium.com,
        michael.chan@...adcom.com, santosh@...lsio.com,
        madalin.bucur@....com, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, jeffrey.t.kirsher@...el.com,
        tariqt@...lanox.com, saeedm@...lanox.com, jiri@...lanox.com,
        idosch@...lanox.com, ganeshgr@...lsio.com,
        jakub.kicinski@...ronome.com, linux-net-drivers@...arflare.com,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, grygorii.strashko@...com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next] net: rename ndo_setup_tc to ndo_setup_offload

Wed, Jul 18, 2018 at 06:14:04PM CEST, pablo@...filter.org wrote:
>One of the recurring complaints is that we do not have, as a driver
>writer, a central location from which we would be fed offloading rules
>into a NIC. This was brought up again during Netconf'18 in Boston.
>
>This patch just renames ndo_setup_tc to ndo_setup_offload as a very
>early initial work to prepare for follow up patches that discuss/propose
>unified flow representation for the existing offload programming APIs:
>ethtool_rxnfc, cls_flower, cls_u32 and (probably, not yet upstream)
>conntrack.
>
>Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Acked-by: Jiri Pirko <jiri@...lanox.com>

It would make sense to also rename following enum:
enum tc_setup_type {
        TC_SETUP_QDISC_MQPRIO,
        TC_SETUP_CLSU32,
        TC_SETUP_CLSFLOWER,
        TC_SETUP_CLSMATCHALL,
        TC_SETUP_CLSBPF,
        TC_SETUP_BLOCK,
        TC_SETUP_QDISC_CBS,
        TC_SETUP_QDISC_RED,
        TC_SETUP_QDISC_PRIO,
        TC_SETUP_QDISC_MQ,
        TC_SETUP_QDISC_ETF,
};

Maybe "enum setup_offload_type" and "SETUP_OFFLOAD_TC_*"?

Could you please do it in a follow-up?

Thanks!