netdev - Re: [PATCH v2] net: dsa: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180719.053333.396851874410198344.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 05:33:33 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        s.mesoraca16@...il.com, f.fainelli@...il.com, andrew@...n.ch,
        David.Laight@...lab.com
Subject: Re: [PATCH v2] net: dsa: Remove VLA usage

From: Kees Cook <keescook@...omium.org>
Date: Mon, 16 Jul 2018 21:10:34 -0700

> From: Salvatore Mesoraca <s.mesoraca16@...il.com>
> 
> We avoid 2 VLAs by using a pre-allocated field in dsa_switch. We also
> try to avoid dynamic allocation whenever possible (when using fewer than
> bits-per-long ports, which is the common case).
> 
> Link: http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> Link: http://lkml.kernel.org/r/20180505185145.GB32630@lunn.ch
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@...il.com>
> [kees: tweak commit subject and message slightly]
> Signed-off-by: Kees Cook <keescook@...omium.org>

Florian and Andrew, please review.