netdev - Re: [PATCH net-next] net/mlx5: fix an unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.053903.2078135194846496238.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 05:39:03 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@....mellanox.co.il
Cc:     arnd@...db.de, saeedm@...lanox.com, leon@...nel.org,
        ilyal@...lanox.com, borisp@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: fix an unused-function warning

From: Saeed Mahameed <saeedm@....mellanox.co.il>
Date: Tue, 17 Jul 2018 17:42:25 -0700

> On Tue, Jul 17, 2018 at 6:49 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> These dummy helpers are all intended to be inline functions,
>> but one of them by accident came without the 'inline' keyword,
>> causing a harmless warning:
>>
>> In file included from drivers/net/ethernet/mellanox/mlx5/core/main.c:63:
>> drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h:79:1: error: 'mlx5_accel_tls_add_flow' defined but not used [-Werror=unused-function]
>>  mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
>>
>> Fixes: ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> Dave, you can take this one to net-next.

Sure, done.