netdev - Re: [PATCH v3 net-next 6/8] lan743x: Add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180719.071552.1853366394480223525.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 07:15:52 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net-next 6/8] lan743x: Add power management support

From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
Date: Wed, 18 Jul 2018 17:04:36 -0400

> +#ifdef CONFIG_PM
> +static void lan743x_ethtool_get_wol(struct net_device *netdev,
> +				    struct ethtool_wolinfo *wol)
> +{
> +	struct lan743x_adapter *adapter = netdev_priv(netdev);
> +
> +	wol->supported = 0;
> +	wol->wolopts = 0;
> +	phy_ethtool_get_wol(netdev->phydev, wol);
> +
> +	wol->supported &= WAKE_BCAST | WAKE_UCAST | WAKE_MCAST |
> +		WAKE_MAGIC | WAKE_PHY | WAKE_ARP;
> +
> +	wol->wolopts &= adapter->wolopts;
> +}
> +#endif /* CONFIG_PM */
> +
> +#ifdef CONFIG_PM

Please remove these "#endif FOO, #ifdef FOO" sequences, and instead just have
one large continuous "ifdef FOO, endif FOO" section.

Thank you.