netdev - Re: [PATCH v2] tcp: identify cryptic messages as TCP seq # bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.072658.90734326288661892.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 07:26:58 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, jidanni@...anni.org
Subject: Re: [PATCH v2] tcp: identify cryptic messages as TCP seq # bugs

From: Randy Dunlap <rdunlap@...radead.org>
Date: Tue, 17 Jul 2018 18:27:45 -0700

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Attempt to make cryptic TCP seq number error messages clearer by
> (1) identifying the source of the message as "TCP", (2) identifying the
> errors as "seq # bug", and (3) grouping the field identifiers and values
> by separating them with commas.
> 
> E.g., the following message is changed from:
> 
> recvmsg bug 2: copied 73BCB6CD seq 70F17CBE rcvnxt 73BCB9AA fl 0
> WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:1881 tcp_recvmsg+0x649/0xb90
> 
> to:
> 
> TCP recvmsg seq # bug 2: copied 73BCB6CD, seq 70F17CBE, rcvnxt 73BCB9AA, fl 0
> WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:2011 tcp_recvmsg+0x694/0xba0
> 
> Suggested-by: 積丹尼 Dan Jacobson <jidanni@...anni.org>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> v2: drop __func__ because it duplicates part of the error message.

Applied, thanks Randy.