netdev - Re: [PATCH 2/5] net: add an info message to eth_platform_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180719.081300.1581730029693790076.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 08:13:00 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     brgl@...ev.pl
Cc:     nsekhar@...com, khilman@...nel.org, linux@...linux.org.uk,
        grygorii.strashko@...com, srinivas.kandagatla@...aro.org,
        lukas@...ner.de, robh@...nel.org, f.fainelli@...il.com,
        dan.carpenter@...cle.com, ivan.khoronzhuk@...aro.org,
        david@...hnology.com, gregkh@...uxfoundation.org, andrew@...n.ch,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        bgolaszewski@...libre.com
Subject: Re: [PATCH 2/5] net: add an info message to
 eth_platform_get_mac_address()

From: Bartosz Golaszewski <brgl@...ev.pl>
Date: Wed, 18 Jul 2018 18:10:32 +0200

>  
> +	dev_info(dev, "read MAC address from %s\n", from);
>  	ether_addr_copy(mac_addr, addr);
>  	return 0;

Ugh, please don't do this.

We probe various bits of information from various sources during
driver probe, and none of them are more or less important than
the MAC address.  So singling this out for log info output is
really not such a great idea.

Thank you.