netdev - Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180718.094028.1268801023597255788.davem@davemloft.net>
Date:   Wed, 18 Jul 2018 09:40:28 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     richardcochran@...il.com, vivien.didelot@...oirfairelinux.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP
 operations

From: Andrew Lunn <andrew@...n.ch>
Date: Tue, 17 Jul 2018 23:48:53 +0200

> @@ -319,6 +337,8 @@ int mv88e6xxx_ptp_setup(struct mv88e6xxx_chip *chip)
>  {
>  	int i;
>  
> +	const struct mv88e6xxx_ptp_ops *ptp_ops = chip->info->ops->ptp_ops;
> +

Please keep the local variables together here.

Otherwise, this series looks good to me.