netdev - Re: [PATCH iproute2 5/5] bpf: implement btf handling and map annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180718180132.4818fa08@cakuba.netronome.com>
Date:   Wed, 18 Jul 2018 18:01:32 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     Daniel Borkmann <daniel@...earbox.net>, <dsahern@...il.com>,
        <alexei.starovoitov@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 5/5] bpf: implement btf handling and map
 annotation

On Wed, 18 Jul 2018 16:52:34 -0700, Martin KaFai Lau wrote:
> On Tue, Jul 17, 2018 at 05:27:43PM -0700, Jakub Kicinski wrote:
> > On Wed, 18 Jul 2018 01:31:22 +0200, Daniel Borkmann wrote:  
> > >   # bpftool map dump id 386
> > >    [{
> > >         "key": 0,
> > >         "value": {
> > >             "": {
> > >                 "value": 0,
> > >                 "ifindex": 0,
> > >                 "mac": []
> > >             }
> > >         }
> > >     },{
> > >         "key": 1,
> > >         "value": {
> > >             "": {
> > >                 "value": 0,
> > >                 "ifindex": 0,
> > >                 "mac": []
> > >             }
> > >         }
> > >     },{
> > >   [...]  
> > 
> > Ugh, the empty keys ("") look worrying, we should probably improve
> > handling of anonymous structs in bpftool :S  
> Note that the kernel's btf_verifier_log is using "(anon)" in this case.
> Not sure if it is a good idea for json.

"(anon)" sounds good, we should probably add some id to it in JSON in
case there are multiple.