netdev - Re: [PATCH bpf-next] bpf: show in bpftool map overview whether btf is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22a5d2b8-7303-ec64-2cfe-7d9b00ebe67d@iogearbox.net>
Date:   Thu, 19 Jul 2018 17:45:57 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: show in bpftool map overview whether btf is
 available

On 07/18/2018 08:08 PM, Jakub Kicinski wrote:
> On Wed, 18 Jul 2018 11:19:42 +0200, Daniel Borkmann wrote:
>> For a quick overview in 'bpftool map' display 'btf' if it's
>> available for the dump for a specific map:
>>
>>   # bpftool map list
>>   11: array  flags 0x0  btf
>>           key 4B  value 20B  max_entries 40  memlock 4096B
>>
>>   # bpftool --json --pretty map list
>>   [{
>>           "id": 11,
>>           "type": "array",
>>           "flags": 0,
>>           "btf_available": true,
>>           "bytes_key": 4,
>>           "bytes_value": 20,
>>           "max_entries": 40,
>>           "bytes_memlock": 4096
>>       }
>>   ]
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> 
> Hmm.. would it make sense to provide the actual BTF IDs instead of just
> yes/no?  At least in JSON?

Yeah that sounds reasonable to me. I think in that case it needs to be
BTF id as well as key and value id inside that BTF object to make some
sense out of it (BTF id alone would not be enough).

Probably makes sense to show the same information in plain text output
then.