netdev - Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV-pcr5OaTN1N-iYQt+KiTKy6U590Z_1e4vv3vebUsMdA@mail.gmail.com>
Date:   Thu, 19 Jul 2018 10:21:06 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        eranbe@...lanox.com
Subject: Re: [PATCH net-next] net: remove redundant input checks in
 SIOCSIFTXQLEN case of dev_ifsioc

On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan <tariqt@...lanox.com> wrote:
> --- a/net/core/dev_ioctl.c
> +++ b/net/core/dev_ioctl.c
> @@ -282,14 +282,7 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
>                 return dev_mc_del_global(dev, ifr->ifr_hwaddr.sa_data);
>
>         case SIOCSIFTXQLEN:
> -               if (ifr->ifr_qlen < 0)
> -                       return -EINVAL;

Are you sure we can remove this if check too?

The other one is safe to remove.