netdev - Re: [PATCH v4 net-next] net/sched: add skbprio scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpV3CRX=uNmQRBfUhcUuaP=ks3=+TOWjENy_FQkrskUdRg@mail.gmail.com>
Date:   Thu, 19 Jul 2018 11:42:24 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nishanth Devarajan <ndev2021@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Cody Doucette <doucette@...edu>,
        Michel Machado <michel@...irati.com.br>
Subject: Re: [PATCH v4 net-next] net/sched: add skbprio scheduler

On Thu, Jul 19, 2018 at 11:23 AM Nishanth Devarajan <ndev2021@...il.com> wrote:
> +static int skbprio_change(struct Qdisc *sch, struct nlattr *opt,
> +                       struct netlink_ext_ack *extack)
> +{
> +       struct skbprio_sched_data *q = qdisc_priv(sch);
> +       struct tc_skbprio_qopt *ctl = nla_data(opt);
> +       const unsigned int min_limit = 1;
> +
> +       if (ctl->limit == (typeof(ctl->limit))-1)
> +               sch->limit = max(qdisc_dev(sch)->tx_queue_len, min_limit);

I am sorry, I still don't like this use of tx_queue_len, it either
should be removed or just align to other existing use cases.

Apologize for responding to your previous email so late.