netdev - Re: [PATCH net] tls: check RCV_SHUTDOWN in tls_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180720.144017.408300928327725195.davem@davemloft.net>
Date:   Fri, 20 Jul 2018 14:40:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     doronrk@...com
Cc:     davejwatson@...com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tls: check RCV_SHUTDOWN in tls_wait_data

From: Doron Roberts-Kedes <doronrk@...com>
Date: Wed, 18 Jul 2018 16:22:27 -0700

> The current code does not check sk->sk_shutdown & RCV_SHUTDOWN.
> tls_sw_recvmsg may return a positive value in the case where bytes have
> already been copied when the socket is shutdown. sk->sk_err has been
> cleared, causing the tls_wait_data to hang forever on a subsequent
> invocation. Checking sk->sk_shutdown & RCV_SHUTDOWN, as in tcp_recvmsg,
> fixes this problem.
> 
> Fixes: c46234ebb4d1 ("tls: RX path for ktls")
> Acked-by: Dave Watson <davejwatson@...com>
> Signed-off-by: Doron Roberts-Kedes <doronrk@...com>

Applied and queued up for -stable, thanks!