netdev - Re: [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.232824.2267856623115325271.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 23:28:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhaochen6@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        aviad.krawczyk@...wei.com, tony.qu@...wei.com,
        yin.yinshi@...wei.com, luoshaokai@...wei.com
Subject: Re: [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame()

From: Zhao Chen <zhaochen6@...wei.com>
Date: Wed, 18 Jul 2018 00:33:18 -0400

> The calculation of "wqe_size" is not correct when the tx queue is busy in
> hinic_xmit_frame().
> 
> When there are no free WQEs, the tx flow will unmap the skb buffer, then
> ring the doobell for the pending packets. But the "wqe_size" which used
> to calculate the doorbell address is not correct. The wqe size should be
> cleared to 0, otherwise, it will cause a doorbell error.
> 
> This patch fixes the problem.
> 
> Reported-by: Zhou Wang <wangzhou1@...ilicon.com>
> Signed-off-by: Zhao Chen <zhaochen6@...wei.com>

Applied and queued up for -stable.