netdev - Re: [PATCH bpf] bpf: Use option "help" in the llvm-objcopy test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34e16aab-db8b-ef38-4c56-6bbf6e81f673@iogearbox.net>
Date:   Fri, 20 Jul 2018 10:37:04 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin KaFai Lau <kafai@...com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...com>, kernel-team@...com
Subject: Re: [PATCH bpf] bpf: Use option "help" in the llvm-objcopy test

On 07/20/2018 07:34 AM, Martin KaFai Lau wrote:
> I noticed the "--version" option of the llvm-objcopy command has recently
> disappeared from the master llvm branch.  It is currently used as a BTF
> support test in tools/testing/selftests/bpf/Makefile.
> 
> This patch replaces it with "--help" which should be
> less error prone in the future.
> 
> Fixes: c0fa1b6c3efc ("bpf: btf: Add BTF tests")
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Looks good, ran into the same recently as well from llvm git. Wondering whether
the "--version" removal there was by accident or on purpose. In any case, applied
to bpf tree, thanks! If we make another change to the Makefile in near future,
we should also make a comment there that the llvm-objcopy is used by pahole -J
internally to make it a bit more clear in case someone is wondering why it's not
used in the Makefile itself.

Thanks,
Daniel