netdev - Re: [PATCH net-next 6/7] net: systemport: Add support for WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f312eccd-8605-e222-9357-1a2d2dbf2984@gmail.com>
Date:   Fri, 20 Jul 2018 02:34:51 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, linville@...driver.com,
        davem@...emloft.net, vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next 6/7] net: systemport: Add support for WAKE_FILTER



On 07/19/2018 03:25 PM, Andrew Lunn wrote:
>> In both of your examples, only one bit is set, what will change is the
>> value being programmed to RXHCK_BRCM_TAG(i), which will be either 0, or
>> 1, but the value programmed to RXCHK_CONTROL as far as which filter is
>> enabled will be the same because we can use filter position 0.
>>
>> What the code basically does is look at how many bits are set in the
>> filters bitmap, and then it starts populating the filters from filter 0
>> up to filter 7 with the value of the bit.
> 
> O.K. Now it get it. Sorry for being so slow.

No worries, thanks for reviewing these changes. I have made the
requested ethtool changes and will post them when I return from vacation
on July 29th.

Thanks Andrew!
-- 
Florian