netdev - Re: [PATCH net] multicast: do not restore deleted record source filter mode to new one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Jul 2018 22:59:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        hideaki.yoshifuji@...aclelinux.com, daniel@...earbox.net
Subject: Re: [PATCH net] multicast: do not restore deleted record source
 filter mode to new one

From: Hangbin Liu <liuhangbin@...il.com>
Date: Fri, 20 Jul 2018 14:04:27 +0800

> There are two scenarios that we will restore deleted records. The first is
> when device down and up(or unmap/remap). In this scenario the new filter
> mode is same with previous one. Because we get it from in_dev->mc_list and
> we do not touch it during device down and up.
> 
> The other scenario is when a new socket join a group which was just delete
> and not finish sending status reports. In this scenario, we should use the
> current filter mode instead of restore old one. Here are 4 cases in total.
> 
> old_socket        new_socket       before_fix       after_fix
>   IN(A)             IN(A)           ALLOW(A)         ALLOW(A)
>   IN(A)             EX( )           TO_IN( )         TO_EX( )
>   EX( )             IN(A)           TO_EX( )         ALLOW(A)
>   EX( )             EX( )           TO_EX( )         TO_EX( )
> 
> Fixes: 24803f38a5c0b (igmp: do not remove igmp souce list info when set link down)
> Fixes: 1666d49e1d416 (mld: do not remove mld souce list info when set link down)
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied and queued up for -stable, thank you.