netdev - Re: [PATCH net] net: rollback orig value on failure of dev_qdisc_change_tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a8fd21-aa7d-5dae-72ba-ef10dcba23f6@mellanox.com>
Date:   Sun, 22 Jul 2018 10:31:12 +0300
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        eranbe@...lanox.com
Subject: Re: [PATCH net] net: rollback orig value on failure of
 dev_qdisc_change_tx_queue_len



On 19/07/2018 8:25 PM, Cong Wang wrote:
> On Thu, Jul 19, 2018 at 7:34 AM Tariq Toukan <tariqt@...lanox.com> wrote:
>>
>> Fix dev_change_tx_queue_len so it rolls back original value
>> upon a failure in dev_qdisc_change_tx_queue_len.
>> This is already done for notifirers' failures, share the code.
>>
>> The revert of changes in dev_qdisc_change_tx_queue_len
>> in such case is needed but missing (marked as TODO), yet it is
>> still better to not apply the new requested value.
> 
> You misunderstand the TODO, that is for reverting tx queue len
> change for previous queues in the loop. I still don't have any
> nice solution for this yet.
> 
I understood this, but maybe didn't describe it clearly. I'll re-phrase.

> Yeah, your change itself looks good.
> 

Thanks.

> Please update the changelog.
> 
> Thanks.
>