netdev - Re: [PATCH] netlink: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180722081246.udphfijsnfnshrsc@breakpoint.cc>
Date:   Sun, 22 Jul 2018 10:12:46 +0200
From:   Florian Westphal <fw@...len.de>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     cscnull@...il.com, Pablo Neira Ayuso <pablo@...filter.org>,
        kadlec@...ckhole.kfki.hu, Florian Westphal <fw@...len.de>,
        David Miller <davem@...emloft.net>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        kstewart@...uxfoundation.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        dsahern@...il.com, lucien.xin@...il.com, ktkhai@...tuozzo.com,
        Cong Wang <xiyou.wangcong@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netlink: fix memory leak

Jason A. Donenfeld <Jason@...c4.com> wrote:
> On Sun, Jul 22, 2018 at 4:51 AM Shaochun Chen <cscnull@...il.com> wrote:
> But even if you moved it somehow to the if(ret), I'm still not sure
> it'd be correct; start cbs should either succeed, or they should error
> out and cleanup entirely after themselves.

I agree, ->done() should not be called if cb->dump() was never invoked.

All ctnetlink and nf_tables spots need to cleanup after themselves.