netdev - Re: [PATCH net] net/ipv6: Fix linklocal to global address with VRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180721.193236.2034280150310979114.davem@davemloft.net>
Date:   Sat, 21 Jul 2018 19:32:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] net/ipv6: Fix linklocal to global address with VRF

From: dsahern@...nel.org
Date: Thu, 19 Jul 2018 12:41:18 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Example setup:
>     host: ip -6 addr add dev eth1 2001:db8:104::4
>            where eth1 is enslaved to a VRF
> 
>     switch: ip -6 ro add 2001:db8:104::4/128 dev br1
>             where br1 only has an LLA
> 
>            ping6 2001:db8:104::4
>            ssh   2001:db8:104::4
> 
> (NOTE: UDP works fine if the PKTINFO has the address set to the global
> address and ifindex is set to the index of eth1 with a destination an
> LLA).
> 
> For ICMP, icmp6_iif needs to be updated to check if skb->dev is an
> L3 master. If it is then return the ifindex from rt6i_idev similar
> to what is done for loopback.
> 
> For TCP, restore the original tcp_v6_iif definition which is needed in
> most places and add a new tcp_v6_iif_l3_slave that considers the
> l3_slave variability. This latter check is only needed for socket
> lookups.
> 
> Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable.

> Dave: I can look at the backports to stable if needed.

Please do, that will help me a lot.