[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180722.102724.533759585465302686.davem@davemloft.net>
Date: Sun, 22 Jul 2018 10:27:24 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: vkuznets@...hat.com
Cc: netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
linux-kernel@...r.kernel.org, boris.ostrovsky@...cle.com,
jgross@...e.com, ross.lagerwall@...rix.com
Subject: Re: [PATCH net-next] xen-netfront: fix queue name setting
From: Vitaly Kuznetsov <vkuznets@...hat.com>
Date: Fri, 20 Jul 2018 18:33:59 +0200
> Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and
> open") changed the initialization order: xennet_create_queues() now
> happens before we do register_netdev() so using netdev->name in
> xennet_init_queue() is incorrect, we end up with the following in
> /proc/interrupts:
>
> 60: 139 0 xen-dyn -event eth%d-q0-tx
> 61: 265 0 xen-dyn -event eth%d-q0-rx
> 62: 234 0 xen-dyn -event eth%d-q1-tx
> 63: 1 0 xen-dyn -event eth%d-q1-rx
>
> and this looks ugly. Actually, using early netdev name (even when it's
> already set) is also not ideal: nowadays we tend to rename eth devices
> and queue name may end up not corresponding to the netdev name.
>
> Use nodename from xenbus device for queue naming: this can't change in VM's
> lifetime. Now /proc/interrupts looks like
>
> 62: 202 0 xen-dyn -event device/vif/0-q0-tx
> 63: 317 0 xen-dyn -event device/vif/0-q0-rx
> 64: 262 0 xen-dyn -event device/vif/0-q1-tx
> 65: 17 0 xen-dyn -event device/vif/0-q1-rx
>
> Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Patch applied, thank you.
Powered by blists - more mailing lists