lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jul 2018 09:17:48 -0600 From: David Ahern <dsahern@...il.com> To: Xin Long <lucien.xin@...il.com>, network dev <netdev@...r.kernel.org> Cc: davem@...emloft.net, Davide Caratti <dcaratti@...hat.com>, idosch@...sch.org Subject: Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed broadcast forwarding On 7/23/18 5:51 AM, Xin Long wrote: > +ping_ipv4() > +{ > + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0 > + > + bc_forwarding_disable > + ping_test_from $h1 198.51.100.255 192.0.2.1 > + ping_test_from $h1 198.51.200.255 192.0.2.1 > + ping_test_from $h1 192.0.2.255 192.0.2.1 > + ping_test_from $h1 255.255.255.255 192.0.2.1 > + > + ping_test_from $h2 192.0.2.255 198.51.100.1 > + ping_test_from $h2 198.51.200.255 198.51.100.1 > + ping_test_from $h2 198.51.100.255 198.51.100.1 > + ping_test_from $h2 255.255.255.255 198.51.100.1 > + bc_forwarding_restore > + > + bc_forwarding_enable > + ping_test_from $h1 198.51.100.255 198.51.100.2 > + ping_test_from $h1 198.51.200.255 198.51.200.2 > + ping_test_from $h1 192.0.2.255 192.0.2.1 1 > + ping_test_from $h1 255.255.255.255 192.0.2.1 > + > + ping_test_from $h2 192.0.2.255 192.0.2.2 > + ping_test_from $h2 198.51.200.255 198.51.200.2 > + ping_test_from $h2 198.51.100.255 198.51.100.1 1 > + ping_test_from $h2 255.255.255.255 198.51.100.1 > + bc_forwarding_restore > + > + sysctl_restore net.ipv4.icmp_echo_ignore_broadcasts You need a better description for each test. This output: TEST: ping_test_from [PASS] TEST: ping_test_from [PASS] TEST: ping_test_from [PASS] TEST: ping_test_from [PASS] ... does not help in understanding which cases are working and which are not.
Powered by blists - more mailing lists