netdev - Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98f02a81-5028-21c8-95cc-9c8c27fa43f8@oracle.com>
Date:   Mon, 23 Jul 2018 09:55:06 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Ka-Cheong Poon <ka-cheong.poon@...cle.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, rds-devel@....oracle.com,
        sowmini.varadhan@...cle.com
Subject: Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support

On 7/23/2018 7:16 AM, Ka-Cheong Poon wrote:
> This patch enables RDS to use IPv6 addresses. For RDS/TCP, the
> listener is now an IPv6 endpoint which accepts both IPv4 and IPv6
> connection requests.  RDS/RDMA/IB uses a private data (struct
> rds_ib_connect_private) exchange between endpoints at RDS connection
> establishment time to support RDMA. This private data exchange uses a
> 32 bit integer to represent an IP address. This needs to be changed in
> order to support IPv6. A new private data struct
> rds6_ib_connect_private is introduced to handle this. To ensure
> backward compatibility, an IPv6 capable RDS stack uses another RDMA
> listener port (RDS_CM_PORT) to accept IPv6 connection. And it
> continues to use the original RDS_PORT for IPv4 RDS connections. When
> it needs to communicate with an IPv6 peer, it uses the RDS_CM_PORT to
> send the connection set up request.
> 
> v4: Changed port history comments in rds.h (Sowmini Varadhan).
> 
> v3: Added support to set up IPv4 connection using mapped address
>      (David Miller).
>      Added support to set up connection between link local and non-link
>      addresses.
>      Various review comments from Santosh Shilimkar and Sowmini Varadhan.
> 
> v2: Fixed bound and peer address scope mismatched issue.
>      Added back rds_connect() IPv6 changes.
> 
> Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
> ---
Looks good to me now. Thanks !!

Acked-by: Santosh Shilimkar <sanstosh.shilimkar@...cle.com>