netdev - Re: [PATCH v5 net-next] net/sched: add skbprio scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUc2XENt05J9zv-czAu5ExVyyX50ecTpV=aQd35nMaubA@mail.gmail.com>
Date:   Mon, 23 Jul 2018 13:47:17 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nishanth Devarajan <ndev2021@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Cody Doucette <doucette@...edu>,
        Michel Machado <michel@...irati.com.br>
Subject: Re: [PATCH v5 net-next] net/sched: add skbprio scheduler

On Mon, Jul 23, 2018 at 7:07 AM Nishanth Devarajan <ndev2021@...il.com> wrote:
>
> net/sched: add skbprio scheduler
>
> Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets
> according to their skb->priority field. Under congestion, already-enqueued lower
> priority packets will be dropped to make space available for higher priority
> packets. Skbprio was conceived as a solution for denial-of-service defenses that
> need to route packets with different priorities as a means to overcome DoS
> attacks.
>
> v5
> *Do not reference qdisc_dev(sch)->tx_queue_len for setting limit. Instead set
> default sch->limit to 64.

Overall, it looks much better now!

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks the update!