netdev - Re: [PATCH] netlink: fix memory leak of dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180723104327.rmptoqx7gzvwvbra@salvia>
Date:   Mon, 23 Jul 2018 12:43:27 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     shaochun chen <cscnull@...il.com>
Cc:     Florian Westphal <fw@...len.de>,
        David Miller <davem@...emloft.net>,
        kadlec <kadlec@...ckhole.kfki.hu>,
        "johannes.berg" <johannes.berg@...el.com>, jason <Jason@...c4.com>,
        ktkhai <ktkhai@...tuozzo.com>,
        "lucien.xin" <lucien.xin@...il.com>,
        "xiyou.wangcong" <xiyou.wangcong@...il.com>,
        dsahern <dsahern@...il.com>,
        netfilter-devel <netfilter-devel@...r.kernel.org>,
        tom <tom@...ntonium.net>, netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] netlink: fix memory leak of dump

On Mon, Jul 23, 2018 at 06:34:36PM +0800, shaochun chen wrote:
> I have a question: we will try_module_get in __netlink_dump_start(),
> but why we need to call try_module_get again in  nft_netlink_dump_start ??

Because they refer to two different modules. nfnetlink is multiplexing
all netfilter subsystem through one single netlink bus.

At the time that decision was made, there were concerns about netlink
running out of busses.