netdev - Re: [PATCH bpf-next] bpf: btf: fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724154549.dulibeesja7ajwni@kafai-mbp>
Date:   Tue, 24 Jul 2018 08:45:49 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     YueHaibing <yuehaibing@...wei.com>
CC:     <ast@...nel.org>, <daniel@...earbox.net>,
        <quentin.monnet@...ronome.com>, <jakub.kicinski@...ronome.com>,
        <bhole_prashant_q7@....ntt.co.jp>, <osk@...com>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>
Subject: Re: [PATCH bpf-next] bpf: btf: fix inconsistent IS_ERR and PTR_ERR

On Tue, Jul 24, 2018 at 10:55:24AM +0800, YueHaibing wrote:
> Fix inconsistent IS_ERR and PTR_ERR in get_btf,
> the proper pointer to be passed as argument is '*btf'
> 
> This issue was detected with the help of Coccinelle.
> 
> Fixes: 2d3feca8c44f ("bpf: btf: print map dump and lookup with btf info")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Acked-by: Martin KaFai Lau <kafai@...com>

> ---
>  tools/bpf/bpftool/map.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index 9c81918..0ee3ba4 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -230,7 +230,7 @@ static int get_btf(struct bpf_map_info *map_info, struct btf **btf)
>  
>  	*btf = btf__new((__u8 *)btf_info.btf, btf_info.btf_size, NULL);
>  	if (IS_ERR(*btf)) {
> -		err = PTR_ERR(btf);
> +		err = PTR_ERR(*btf);
>  		*btf = NULL;
>  	}
>  
> -- 
> 2.7.0
> 
>