netdev - Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d76a2b15-8bc8-c745-ad27-840a8b57a1c3@gmail.com>
Date:   Tue, 24 Jul 2018 12:36:07 -0600
From:   David Ahern <dsahern@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
        Davide Caratti <dcaratti@...hat.com>,
        Ido Schimmel <idosch@...sch.org>
Subject: Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed
 broadcast forwarding

On 7/24/18 11:55 AM, Xin Long wrote:
> INFO: bc_forwarding disabled on r1 =>
> INFO: h1 -> net2: reply from r1 (not forwarding)
> TEST: ping 198.51.100.255, expected reply from 192.0.2.1            [PASS]
> INFO: h1 -> net3: reply from r1 (not forwarding)
> TEST: ping 198.51.200.255, expected reply from 192.0.2.1            [PASS]
> INFO: h1 -> net1: reply from r1 (not dropping)
> TEST: ping 192.0.2.255, expected reply from 192.0.2.1               [PASS]
> ....
> how about this?

Personally, I think that is backwards. So like this:

INFO: bc_forwarding disabled on r1 =>
INFO: ping 198.51.100.255, expected reply from 192.0.2.1
TEST: h1 -> net2: reply from r1 (not forwarding)              [PASS]
INFO: ping 198.51.200.255, expected reply from 192.0.2.1
TEST: h1 -> net3: reply from r1 (not forwarding)              [PASS]
INFO: ping 192.0.2.255, expected reply from 192.0.2.1
TEST: h1 -> net1: reply from r1 (not dropping)                [PASS]
...