netdev - Re: bisected: 4.18-rc* regression: x86-32 troubles (with timers?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc29beb2-f4c5-3d6c-2b64-1c0e11af4241@iogearbox.net>
Date:   Tue, 24 Jul 2018 20:40:29 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Meelis Roos <mroos@...ux.ee>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux Kernel list <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: bisected: 4.18-rc* regression: x86-32 troubles (with timers?)

On 07/24/2018 06:47 AM, Meelis Roos wrote:
>>> Anyway, I started compile of v4.18-rc5 that was the latest I tested, 
>>> with the commit in question reverted. Will see if I can test tomorrow 
>>> morning. But I will leave tomorrow for a week and can only test further 
>>> things if they happen to boot fine (no manual reboot possible for a 
>>> week).
>>
>> Ok, thanks, please keep us posted on the outcome with the revert. Right
>> now I would doubt it's related resp. changes anything on the issue, but
>> lets see.
> 
> v4.18-rc5 minus the patch in question worked fine on 2 bootups so it 
> seems to be good.

And this was with CONFIG_BPF_JIT_ALWAYS_ON=y, correct? Could you try the
same with this below applied:

diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c
index 5579987..313c983 100644
--- a/arch/x86/net/bpf_jit_comp32.c
+++ b/arch/x86/net/bpf_jit_comp32.c
@@ -175,7 +175,7 @@ static const u8 bpf2ia32[][2] = {
 #define SCRATCH_SIZE 96

 /* Total stack size used in JITed code */
-#define _STACK_SIZE	(stack_depth + SCRATCH_SIZE)
+#define _STACK_SIZE	(stack_depth + SCRATCH_SIZE + 4)

 #define STACK_SIZE ALIGN(_STACK_SIZE, STACK_ALIGNMENT)


Thanks,
Daniel