netdev - Re: [PATCH net] r8169: restore previous behavior to accept BIOS WoL settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180724.140727.1181245356417253291.davem@davemloft.net>
Date:   Tue, 24 Jul 2018 14:07:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, aacid@....org
Subject: Re: [PATCH net] r8169: restore previous behavior to accept BIOS
 WoL settings

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 24 Jul 2018 22:21:04 +0200

> Commit 7edf6d314cd0 tried to resolve an inconsistency (BIOS WoL
> settings are accepted, but device isn't wakeup-enabled) resulting
> from a previous broken-BIOS workaround by making disabled WoL the
> default.
> This however had some side effects, most likely due to a broken BIOS
> some systems don't properly resume from suspend when the MagicPacket
> WoL bit isn't set in the chip, see
> https://bugzilla.kernel.org/show_bug.cgi?id=200195
> Therefore restore the WoL behavior from 4.16.
> 
> Reported-by: Albert Astals Cid <aacid@....org>
> Fixes: 7edf6d314cd0 ("r8169: disable WOL per default")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable.

> This patch will cause a trivial merge conflict when merging net
> to net-next.

Thanks for the heads up.