netdev - Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180723.202033.1935833384843765067.davem@davemloft.net>
Date:   Mon, 23 Jul 2018 20:20:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ka-cheong.poon@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com,
        rds-devel@....oracle.com, sowmini.varadhan@...cle.com
Subject: Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support

From: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
Date: Tue, 24 Jul 2018 11:18:24 +0800

> On 07/24/2018 02:15 AM, David Miller wrote:
>> From: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
>> Date: Mon, 23 Jul 2018 07:16:11 -0700
>> 
>>> @@ -163,15 +165,29 @@ int rds_tcp_accept_one(struct socket *sock)
>>>     	inet = inet_sk(new_sock->sk);
>>>   +	my_addr = &new_sock->sk->sk_v6_rcv_saddr;
>>> +	peer_addr = &new_sock->sk->sk_v6_daddr,
>>>   	rdsdebug("accepted tcp %pI6c:%u -> %pI6c:%u\n",
>> Note that comma, instead of a semicolon, at the end of the peer_addr
>> assignment.
>> This doesn't even compile.
> 
> 
> Strange, the compiler did not complain.  Will check why's
> that.

Try allmodconfig