netdev - Re: [PATCH net] sock: fix sg page frag coalescing in sk_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180723.212925.1494040388709274706.davem@davemloft.net>
Date:   Mon, 23 Jul 2018 21:29:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     daniel@...earbox.net
Cc:     netdev@...r.kernel.org, davejwatson@...com, borisp@...lanox.com,
        john.fastabend@...il.com
Subject: Re: [PATCH net] sock: fix sg page frag coalescing in sk_alloc_sg

From: Daniel Borkmann <daniel@...earbox.net>
Date: Mon, 23 Jul 2018 22:37:54 +0200

> Current sg coalescing logic in sk_alloc_sg() (latter is used by tls and
> sockmap) is not quite correct in that we do fetch the previous sg entry,
> however the subsequent check whether the refilled page frag from the
> socket is still the same as from the last entry with prior offset and
> length matching the start of the current buffer is comparing always the
> first sg list entry instead of the prior one.
> 
> Fixes: 3c4d7559159b ("tls: kernel TLS support")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Dave Watson <davejwatson@...com>

Applied and queued up for -stable, thanks Daniel.