netdev - [PATCH] Make Surface Dock 3 work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <873212f4-8e8d-df81-683e-03f3b75659d2@uib.de>
Date:   Tue, 24 Jul 2018 12:08:45 +0200
From:   Mathias Radtke <m.radtke@....de>
To:     oliver@...kum.org, hayeswang@...ltek.com, netdev@...r.kernel.org
Subject: [PATCH] Make Surface Dock 3 work again

Hi,

since Kernel 4.10 the usage of the Surface Dock 3 is broken.
The network driver r8152 reports Tx Error -71.
The patch removes the dock from the r8152 driver and also removed it 
from the cdc_ether drivers blacklist. Therefore the cdc_driver takes 
over and the dock works again.

diff -uprN -X linux-vanilla/Documentation/dontdiff 
linux-vanilla/drivers/net/usb/cdc_ether.c linux/drivers/net/usb/cdc_ether.c
--- linux-vanilla/drivers/net/usb/cdc_ether.c    2018-07-24 
07:53:47.474426679 +0200
+++ linux/drivers/net/usb/cdc_ether.c    2018-07-24 07:55:24.268740306 +0200
@@ -807,13 +807,6 @@ static const struct usb_device_id    produc
      .driver_info = 0,
  },

-/* Microsoft Surface 3 dock (based on Realtek RTL8153) */
-{
-    USB_DEVICE_AND_INTERFACE_INFO(MICROSOFT_VENDOR_ID, 0x07c6, 
USB_CLASS_COMM,
-            USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
-    .driver_info = 0,
-},
-
      /* TP-LINK UE300 USB 3.0 Ethernet Adapters (based on Realtek 
RTL8153) */
  {
      USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, 0x0601, 
USB_CLASS_COMM,
diff -uprN -X linux-vanilla/Documentation/dontdiff 
linux-vanilla/drivers/net/usb/r8152.c linux/drivers/net/usb/r8152.c
--- linux-vanilla/drivers/net/usb/r8152.c    2018-07-24 
07:53:47.494426331 +0200
+++ linux/drivers/net/usb/r8152.c    2018-07-24 07:55:05.705064110 +0200
@@ -5323,7 +5323,6 @@ static const struct usb_device_id rtl815
      {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
      {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
      {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
-    {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
      {REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
      {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO,  0x304f)},
      {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO,  0x3062)},


Cheers

-- 
Mathias Radtke


---

http://uib.de/de/support-schulung/schulung/

uib gmbh
Bonifaziusplatz 1B
55118 Mainz

E-Mail: m.radtke@....de
Internet: www.uib.de

Geschäftsführer: dr. detlef oertel & erol ueluekmen
Handelsregister: Amtsgericht Mainz HRB 6942