netdev - Re: [PATCH net-next] net: igmp: make function __ip_mc_inc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e451e3f1-6cfc-6966-45a4-84b08fae008a@gmail.com>
Date:   Wed, 25 Jul 2018 06:19:56 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group()
 static



On 07/24/2018 11:06 PM, Wei Yongjun wrote:
> Fixes the following sparse warnings:
> 
> net/ipv4/igmp.c:1391:6: warning:
>  symbol '__ip_mc_inc_group' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  net/ipv4/igmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 598333b..c9f8d46 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev,
>  /*
>   *	A socket has joined a multicast group on device dev.
>   */
> -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode)
> +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr,
> +			      unsigned int mode)
>  {
>  	struct ip_mc_list *im;
>  #ifdef CONFIG_IP_MULTICAST
> 

This should target net tree

Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group")