netdev - Re: [PATCH bpf] xsk: fix poll/POLLIN premature returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4444630-0c6f-a95e-136c-4c4fb24e83f6@iogearbox.net>
Date:   Wed, 25 Jul 2018 19:00:13 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        magnus.karlsson@...el.com, ast@...com, netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        qi.z.zhang@...el.com
Subject: Re: [PATCH bpf] xsk: fix poll/POLLIN premature returns

On 07/23/2018 11:43 AM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> Polling for the ingress queues relies on reading the producer/consumer
> pointers of the Rx queue.
> 
> Prior this commit, a cached consumer pointer could be used, instead of
> the actual consumer pointer and therefore report POLLIN prematurely.
> 
> This patch makes sure that the non-cached consumer pointer is used
> instead.
> 
> Reported-by: Qi Zhang <qi.z.zhang@...el.com>
> Tested-by: Qi Zhang <qi.z.zhang@...el.com>
> Fixes: c497176cb2e4 ("xsk: add Rx receive functions and poll support")
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>

Applied thanks, Björn!