netdev - Re: [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNh19+_7oPBXAfGYksKRGHD=B1pJ6qfu8ta_BDza75YsGw@mail.gmail.com>
Date:   Thu, 26 Jul 2018 14:18:27 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Brian Brooks <brian.brooks@...aro.org>
Cc:     ast@...nel.org, Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64

Den ons 25 juli 2018 kl 23:09 skrev Brian Brooks <brian.brooks@...aro.org>:
>
> Define u_smp_rmb() and u_smp_wmb() to respective barrier instructions.
> This ensures the processor will order accesses to queue indices against
> accesses to queue ring entries.
>

Thanks Brian!

Acked-by: Björn Töpel <bjorn.topel@...el.com>

> Signed-off-by: Brian Brooks <brian.brooks@...aro.org>
> ---
>  samples/bpf/xdpsock_user.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> index 5904b1543831..1e82f7c617c3 100644
> --- a/samples/bpf/xdpsock_user.c
> +++ b/samples/bpf/xdpsock_user.c
> @@ -145,8 +145,13 @@ static void dump_stats(void);
>         } while (0)
>
>  #define barrier() __asm__ __volatile__("": : :"memory")
> +#ifdef __aarch64__
> +#define u_smp_rmb() __asm__ __volatile__("dmb ishld": : :"memory")
> +#define u_smp_wmb() __asm__ __volatile__("dmb ishst": : :"memory")
> +#else
>  #define u_smp_rmb() barrier()
>  #define u_smp_wmb() barrier()
> +#endif
>  #define likely(x) __builtin_expect(!!(x), 1)
>  #define unlikely(x) __builtin_expect(!!(x), 0)
>
> --
> 2.18.0
>