netdev - Re: [PATCH] net: fix amd-xgbe flow-control issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c28089a-7a2b-c279-2905-b6a533b87932@amd.com>
Date:   Thu, 26 Jul 2018 08:13:28 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     tli012345@....com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, tangpengpeng <tangpengpeng@...on.com>
Subject: Re: [PATCH] net: fix amd-xgbe flow-control issue

On 7/26/2018 1:45 AM, tli012345@....com wrote:
> From: tangpengpeng <tangpengpeng@...on.com>
> 
> If we enable or disable xgbe flow-control by ethtool ,
> it does't work.Because the parameter is not properly
> assigned,so we need to adjust the assignment order
> of the parameters.
> 
> Signed-off-by: tangpengpeng <tangpengpeng@...on.com>

You should add a Fixes tag as this bug was introduced with commit:

  c1ce2f77366b ("amd-xgbe: Fix flow control setting logic")

And since that commit was introduced in 4.2, you'll want to ask David to
push this to stable (4.4 and higher).

With that,

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 4b5d625de8f0..8a3a60bb2688 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -1111,14 +1111,14 @@ static void xgbe_phy_adjust_link(struct xgbe_prv_data *pdata)
>  
>  		if (pdata->tx_pause != pdata->phy.tx_pause) {
>  			new_state = 1;
> -			pdata->hw_if.config_tx_flow_control(pdata);
>  			pdata->tx_pause = pdata->phy.tx_pause;
> +			pdata->hw_if.config_tx_flow_control(pdata);
>  		}
>  
>  		if (pdata->rx_pause != pdata->phy.rx_pause) {
>  			new_state = 1;
> -			pdata->hw_if.config_rx_flow_control(pdata);
>  			pdata->rx_pause = pdata->phy.rx_pause;
> +			pdata->hw_if.config_rx_flow_control(pdata);
>  		}
>  
>  		/* Speed support */
>