netdev - RE: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jul 2018 02:18:25 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ying.xue@...driver.com" <ying.xue@...driver.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next] tipc: add missing dev_put() on error in
 tipc_enable_l2_media

Acked
///Jon Maloy

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On Behalf Of YueHaibing
> Sent: Wednesday, 25 July, 2018 05:01
> To: davem@...emloft.net; Jon Maloy <jon.maloy@...csson.com>; ying.xue@...driver.com
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net; YueHaibing
> <yuehaibing@...wei.com>
> Subject: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media
> 
> when tipc_own_id failed to obtain node identity,dev_put should
> be call before return -EINVAL.
> 
> Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/tipc/bearer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index fd6d8f1..418f03d 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -395,6 +395,7 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
>  		tipc_net_init(net, node_id, 0);
>  	}
>  	if (!tipc_own_id(net)) {
> +		dev_put(dev);
>  		pr_warn("Failed to obtain node identity\n");
>  		return -EINVAL;
>  	}
> --
> 2.7.0
>