netdev - Re: [PATCH net v2] net: rollback orig value on failure of dev_qdisc_change_tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180726.140131.760557655200384644.davem@davemloft.net>
Date:   Thu, 26 Jul 2018 14:01:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net v2] net: rollback orig value on failure of
 dev_qdisc_change_tx_queue_len

From: Tariq Toukan <tariqt@...lanox.com>
Date: Tue, 24 Jul 2018 14:12:20 +0300

> Fix dev_change_tx_queue_len so it rolls back original value
> upon a failure in dev_qdisc_change_tx_queue_len.
> This is already done for notifirers' failures, share the code.
> 
> In case of failure in dev_qdisc_change_tx_queue_len, some tx queues
> would still be of the new length, while they should be reverted.
> Currently, the revert is not done, and is marked with a TODO label
> in dev_qdisc_change_tx_queue_len, and should find some nice solution
> to do it.
> Yet it is still better to not apply the newly requested value.
> 
> Fixes: 48bfd55e7e41 ("net_sched: plug in qdisc ops change_tx_queue_len")
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> Reviewed-by: Eran Ben Elisha <eranbe@...lanox.com>
> Reported-by: Ran Rozenstein <ranro@...lanox.com>

Applied and queued up for -stable.