netdev - Re: [PATCH net-next] l2tp: remove ->recv_payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180726.140738.714063342671290482.davem@davemloft.net>
Date:   Thu, 26 Jul 2018 14:07:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next] l2tp: remove ->recv_payload_hook

From: Guillaume Nault <g.nault@...halink.fr>
Date: Wed, 25 Jul 2018 14:53:33 +0200

> The tunnel reception hook is only used by l2tp_ppp for skipping PPP
> framing bytes. This is a session specific operation, but once a PPP
> session sets ->recv_payload_hook on its tunnel, all frames received by
> the tunnel will enter pppol2tp_recv_payload_hook(), including those
> targeted at Ethernet sessions (an L2TPv3 tunnel can multiplex PPP and
> Ethernet sessions).
> 
> So this mechanism is wrong, and uselessly complex. Let's just move this
> functionality to the pppol2tp rx handler and drop ->recv_payload_hook.
> 
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied, thanks Guillaume.