netdev - Re: [PATCH net-next v4 4/4] act_mirred: use TC_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWU7-9F8fhXvYkWHmuKzQsnLfhSenHieefvB3q_rTAKzA@mail.gmail.com>
Date:   Thu, 26 Jul 2018 16:27:51 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Daniel Borkmann <daniel@...earbox.net>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Eyal Birger <eyal.birger@...il.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next v4 4/4] act_mirred: use TC_ACT_REINSERT when possible

On Thu, Jul 26, 2018 at 7:35 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> When mirred is invoked from the ingress path, and it wants to redirect
> the processed packet, it can now use the TC_ACT_REINSERT action,
> filling the tcf_result accordingly, and avoiding a per packet
> skb_clone().
>
> Overall this gives a ~10% improvement in forwarding performance for the
> TC S/W data path and TC S/W performances are now comparable to the
> kernel openvswitch datapath.
>
> v1 -> v2: use ACT_MIRRED instead of ACT_REDIRECT
> v2 -> v3: updated after action rename, fixed typo into the commit
>         message
> v3 -> v4: updated again after action rename, added more comments to
>         the code (JiriP), skip the optimization if the control action
>         need to touch the tcf_result (Paolo)
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Overall it looks good to me now.

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks!