netdev - Re: [PATCH 06/18] netlink: Do not subscribe to non-existent groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180725.212258.182134114222639499.davem@davemloft.net>
Date:   Wed, 25 Jul 2018 21:22:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dima@...sta.com
Cc:     linux-kernel@...r.kernel.org, herbert@...dor.apana.org.au,
        steffen.klassert@...unet.com, 0x7f454c46@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH 06/18] netlink: Do not subscribe to non-existent groups

From: Dmitry Safonov <dima@...sta.com>
Date: Thu, 26 Jul 2018 03:31:32 +0100

> Make ABI more strict about subscribing to group > ngroups.
> Code doesn't check for that and it looks bogus.
> (one can subscribe to non-existing group)
> Still, it's possible to bind() to all possible groups with (-1)
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

This really has nothing to do with adding a compat layer for xfrm,
and is a bug fix that should be submitted separately in it's own
right.