netdev - Re: [PATCH] isdn: mISDN: hfcpci: Replace GFP_ATOMIC with GFP_KERNEL in hfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180726.212451.594057106065516510.davem@davemloft.net>
Date:   Thu, 26 Jul 2018 21:24:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@...il.com
Cc:     isdn@...ux-pingi.de, keescook@...omium.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: mISDN: hfcpci: Replace GFP_ATOMIC with
 GFP_KERNEL in hfc_probe()

From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Fri, 27 Jul 2018 10:39:06 +0800

> hfc_probe() is never called in atomic context.
> It calls kzalloc() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied.