netdev - Re: [PATCH v5 bpf-next 3/9] veth: Avoid drops by oversized packets when XDP is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180726180847.39bf2da1@cakuba.netronome.com>
Date:   Thu, 26 Jul 2018 18:08:47 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc:     Toshiaki Makita <toshiaki.makita1@...il.com>,
        netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH v5 bpf-next 3/9] veth: Avoid drops by oversized packets
 when XDP is enabled

On Fri, 27 Jul 2018 10:06:41 +0900, Toshiaki Makita wrote:
> On 2018/07/27 9:51, Jakub Kicinski wrote:
> > On Thu, 26 Jul 2018 23:40:26 +0900, Toshiaki Makita wrote:  
> >> +		max_mtu = PAGE_SIZE - VETH_XDP_HEADROOM -
> >> +			  peer->hard_header_len -
> >> +			  SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
> >> +		if (peer->mtu > max_mtu) {
> >> +			NL_SET_ERR_MSG_MOD(extack, "Peer MTU is too large to set XDP");
> >> +			err = -ERANGE;
> >> +			goto err;
> >> +		}  
> > 
> > You need to add .ndo_change_mtu and check this condition there too.  
> 
> I'm setting peer->max_mtu so no need to add .ndo_change_mtu.
> Inappropriate MTU will be refused in dev_set_mtu().

missed that, sorry